allow asyncio in workflow deterministic path processing #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filintod
commented
Aug 20, 2025
|
|
||
| ### Configuration | ||
|
|
||
| The SDK connects to a Durable Task sidecar. By default it uses `localhost:4001`. You can override via environment variables (checked in order): |
There was a problem hiding this comment.
this is actually only in tests
Signed-off-by: Filinto Duran <[email protected]>
filintod
force-pushed
the
filinto/asyncio
branch
from
3670811 to
e27e93b
Compare
filintod
changed the title
…able, some cleanup on duplicated files, refactor aio Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Change variable name from 'eventType' to 'event_type' in the unknown event handler to avoid UnboundLocalError when an unhandled event type is encountered. This bug was triggered when Dapr 1.16 introduced new event types or workflows that our code doesn't handle, causing the code to fall through to the else branch where the variable scoping issue manifested. The fix ensures proper error reporting for unknown event types without encountering a Python scoping error.
refactor: clean up debug print statements and improve code formatting Removed unnecessary debug print statements from the TaskHubGrpcClient class to streamline the code and enhance readability. Additionally, adjusted formatting in various files for consistency, including property definitions and string formatting. This update aims to improve code maintainability and clarity. Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds capability to run asyncio code as part of the deterministic path. This allows users code that have been developed without using deterministic workflow context.
This is different to #17 that is targeting the client api surface, so there is no real overlap.